Skip to content

regression: fix app installation #35888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 1 commit into from
Apr 29, 2025
Merged

regression: fix app installation #35888

kodiakhq merged 1 commit into from
Apr 29, 2025

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Apr 28, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

The changes introduced here ended up modifying the object reference sent to the create function that inserts a new app document in the database, but that function counted on modifying the object it received to assign the inserted id.

This caused routines that relied on the inserted id of the app storage record to stop working - namely private api endpoint registration

Issue(s)

Steps to test or reproduce

Further comments

CONN-625

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 28, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2025

⚠️ No Changeset found

Latest commit: 42926bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added this to the 7.6.0 milestone Apr 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35888/

Built to branch gh-pages at 2025-04-28 19:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.12%. Comparing base (6f70529) to head (42926bf).
Report is 1 commits behind head on release-7.6.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.6.0   #35888      +/-   ##
=================================================
+ Coverage          57.14%   61.12%   +3.97%     
=================================================
  Files               2445     3153     +708     
  Lines              63915    74549   +10634     
  Branches           14126    16667    +2541     
=================================================
+ Hits               36525    45566    +9041     
- Misses             25011    25884     +873     
- Partials            2379     3099     +720
Flag Coverage Δ
e2e 57.85% <ø> (+11.58%) ⬆️
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert marked this pull request as ready for review April 29, 2025 17:18
@d-gubert d-gubert requested a review from a team as a code owner April 29, 2025 17:18
@d-gubert d-gubert requested a review from sampaiodiego April 29, 2025 18:46
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Apr 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 29, 2025
@kodiakhq kodiakhq bot merged commit 292fab4 into release-7.6.0 Apr 29, 2025
53 checks passed
@kodiakhq kodiakhq bot deleted the regression/app-installation-ignore-undefined branch April 29, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@d-gubert @sampaiodiego